Main > Live #2122
Open
Main > Live #2122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix oobe delete user path Rename best practices to recommendations Minor writing style updates
Azure virtual machine does support Nested Virtualization, but cannot use with Trusted Launch. Hence proposing minor correction.
Updated that the hostname takes a lowercase -i as the address flag. This can be seen by running hostname --help. also made the "under the hood" section more verbose with the full length ip-address command.
* Add note for blocked Microsoft Store * Editorial update --------- Co-authored-by: Matt Wojciakowski <[email protected]>
… should be run as administrator before executing the shutdown command. (#2028) * Update WSL shutdown instructions for clarity by specifying PowerShell should be run as administrator before executing the shutdown command. * Add Docker Desktop error recommendation --------- Co-authored-by: Matt Wojciakowski <[email protected]>
…2076) * Add documentation for shortcut.enabled and windowsterminal.enabled * Small fixes
WSL default behaviour changed as of May 2024
* Put the whole command in a block Without this change, the command gets inline and breaks at the beginning, confusing the reader, making them think the command begins by route instead of ip * Update WSL/networking.md --------- Co-authored-by: Craig Loewen <[email protected]>
* make sure the systemd-sysv package is installed * Update WSL/systemd.md --------- Co-authored-by: Craig Loewen <[email protected]>
* WSL/wsl-config.md: rewrite lead for clarity This is a rewrite of the lead section, as I feel the previous one was long-winded yet did not meaningfully summarize the most important points of the article. * Minor changes to this table format update --------- Co-authored-by: Matt Wojciakowski <[email protected]>
* Update wsl-database.md Update the Microsoft SQL Server installation link to SQL Server on WSL 2 * Updated to fix link and streamline title. --------- Co-authored-by: Matt Wojciakowski <[email protected]>
* Update systemd.md State that `wsl --version` command could throws an error if outdated and therefore it must be updated to make systemd working on the distribution. * Update formatting --------- Co-authored-by: Matt Wojciakowski <[email protected]>
|
Learn Build status updates of commit 17dbd9e: ❌ Validation status: errorsPlease follow instructions here which may help to resolve issue.
For more details, please refer to the build report. Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them. For any questions, please:
|
|
@craigloewen-msft - Everything look to merge? |
|
Learn Build status updates of commit 5acf1af: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
LiCaoZ
reviewed
Feb 10, 2025
Comment on lines
59
to
60
| "contributors_to_exclude": [ | ||
| "VSC-Service-Account" |
There was a problem hiding this comment.
L59-L61 are no longer useful and can now be removed. (I don't know why I can't select L61, but this item seems to occasionally come back in 5acf1af, so please consider removing it.
|
Learn Build status updates of commit 790501c: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.